[Webkit-unassigned] [Bug 58242] [GTK] Implement pixel dump support for WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58242





--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2011-04-11 12:39:26 PST ---
(From update of attachment 89035)
View in context: https://bugs.webkit.org/attachment.cgi?id=89035&action=review

This change looks great! I've added a few comments for future thought.  I don't think anything I mention is worth addressing in this change, except perhaps the "ref" call.

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:42
> +

Note: I'm not at all sure that this ref() is needed here.  In CoreGraphics, the allocation of the image surface includes a callback routine that performs the cleanup.  We might need to either omit this ref() here, or make sure that the destructor for the PassOwnPtr<GraphicsContext> somehow decrements the reference count here.

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:61
> +

Note that I cribbed most (all?) of this routine from ImageCairo.cpp.  It would be nice if this could be shared someplace common for both implementations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.