[Webkit-unassigned] [Bug 42432] Enable Web Timing for GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42432





--- Comment #7 from Sergio Villar Senin <svillar at igalia.com>  2011-04-11 10:29:24 PST ---
(From update of attachment 84869)
View in context: https://bugs.webkit.org/attachment.cgi?id=84869&action=review

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:63
> +using namespace WTF;

Do we really need this?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:412
> +                                         0, 0, 0, 0, handle);

We do this in cleanupSoupRequestOperation, why would we need this here?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:573
> +}

This seems correct but the problem is that you are handling the "connection-created" signal of any request issued to the SoupSession. Take into account that this callback will be called whenever the SoupSession needs to create a connection (and not only for this particular ResourceHandle). There are some other problems too, see below in the g_signal_connect() part

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:587
> +}

Same problem than above, the difference is that in this case you are able to check that the SoupMessage provided by libsoup in the second argument is the same than the one you have in d->m_soupMessage. Otherwise you'll have to discard it as it will be handled by another ResourceHandle.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:646
> +    g_signal_connect(session, "connection-created", G_CALLBACK(connectionCreatedCallback), handle);

This is not going to work for one reason. libsoup reuses the connections that have not been closed by the server whenever possible. In such cases libsoup just uses the connections, so no new connection is created and thus, the "connection-created" signal won't be emitted.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:879
> +    g_signal_connect(session, "connection-created", G_CALLBACK(connectionCreatedCallback), handle);

Same comment than in the other "conneciton-created" signal connection and something more. Non-HTTP protocols may not involve any kind of network connection at all, for example data: or file:. For those protocols the "connection-created" signal does not make any sense as no connections are used.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.