[Webkit-unassigned] [Bug 57068] [GTK] [WebKit2] Implement a basic WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57068





--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-04-11 09:22:01 PST ---
(From update of attachment 88932)
View in context: https://bugs.webkit.org/attachment.cgi?id=88932&action=review

>> Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:52
>> +    g_object_set(settings, "gtk-xft-rgba", "none", NULL);
> 
> While calling g_object_set() again? you can just add "gtk-xft-rgba", "none" to the first g_object_set call.

Ah, right, this should move up into the previous block. For a particular test it needs to move, but I'm not sure if it's possible to get the test name at this point in the file.

>> Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:176
>> +    inititializeFontConfigSetting();
> 
> isn't this function X11 specific?

It's specific to ports that use FontConfig. As far as I know we are phasing out non-FontConfig builds.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.