[Webkit-unassigned] [Bug 56393] Without checking existence of the renderer of the element, tries to access the enclosing layer.

Mon Apr 11 06:04:18 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56393

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org

--- Comment #4 from Eric Seidel <eric at webkit.org>  2011-04-11 06:04:18 PST ---
Suchi sent me this in email:

I am wondering if you could help me out about the testcase for bug #56393, you had denied to review the patch as I did not provide the testcase. As this is just a NULL check, I am not able to create layout testcase for this yet. If renderer is null on a generic case, the control does not even come to this function and will crash much beyond. I see the existence of same NULL check in function RenderView::paintBoxDecorations() in file RenderView.cpp. If you could let me know any existense test case for the same NULL check would be great.

My response:

So I'm confused why we're adding this null check if this is never null?  What case is it ever null that we need this null check for?  Do you have an example page which crashes?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.