[Webkit-unassigned] [Bug 54456] Optimizing lightning filter to ARM-neon SIMD instruction set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54456





--- Comment #41 from Zoltan Herczeg <zherczeg at webkit.org>  2011-04-11 01:36:00 PST ---
> > Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h:44
> > +#define FLAG_POINT_LIGHT                 0x01
> > +#define FLAG_SPOT_LIGHT                  0x02
> > +#define FLAG_CONE_EXPONENT_IS_1          0x04
> > +
> > +// Otherwise: Diffuse light.
> > +#define FLAG_SPECULAR_LIGHT              0x10
> > +#define FLAG_DIFFUSE_CONST_IS_1          0x20
> > +#define FLAG_SPECULAR_EXPONENT_IS_1      0x40
> 
> Can't we use enums for this?
> enum LightingFlags (
>     FlagPointLight = 1 << 0,
> ..
> };

Unfortunately not. The preprocessor cannot stringize them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.