[Webkit-unassigned] [Bug 57835] [GTK] Initial loader client implementation in WebKitWebView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 10 23:37:27 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57835





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-04-10 23:37:27 PST ---
(In reply to comment #5)
> (From update of attachment 88441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88441&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:120
> > +
> > +    g_object_class_install_property(gobjectClass,
> > +                                    PROP_TITLE,
> > +                                    g_param_spec_string("title",
> > +                                                        "Title",
> > +                                                        "Returns the @web_view's document title",
> > +                                                        0,
> > +                                                        G_PARAM_READABLE));
> > +    g_object_class_install_property(gobjectClass,
> > +                                    PROP_URI,
> > +                                    g_param_spec_string("uri",
> > +                                                        "URI",
> > +                                                        "Returns the current URI of the contents displayed by the @web_view",
> > +                                                        0,
> > +                                                        G_PARAM_READABLE));
> > +    g_object_class_install_property(gobjectClass,
> > +                                    PROP_PROGRESS,
> > +                                    g_param_spec_double("progress",
> > +                                                        "Progress",
> > +                                                        "Determines the current progress of the load",
> > +                                                        0.0, 1.0, 1.0,
> > +                                                        G_PARAM_READABLE));
> 
> Maybe stating to add the doc of the API it is a good idea.

Yes, it's a matter of copy and paste from webkit1, I haven't included the docs in this first patches to make them simple. 

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:139
> > +    // TODO: update load-status property
> 
> In this cases we are using NotImplemented without the TODO comment, I would stick to that and add the comment just in case it adds any other information.

Ok, I'll add it, the TDO comment was to remember that load-status property is what should be updated there, and not emit the load-* signals that are deprecated. Hopefully this won't be unimplemented for long time :-)

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:287
> > +    WKPageLoaderClient loadClient = {
> > +        0,       /* version */
> > +        webView, /* clientInfo */
> > +        didStartProvisionalLoadForFrame,
> > +        didReceiveServerRedirectForProvisionalLoadForFrame,
> > +        didFailProvisionalLoadWithErrorForFrame,
> > +        didCommitLoadForFrame,
> > +        didFinishDocumentLoadForFrame,
> > +        didFinishLoadForFrame,
> > +        didFailLoadWithErrorForFrame,
> > +        0, /* didSameDocumentNavigationForFrame */
> > +        didReceiveTitleForFrame,
> > +        didFirstLayoutForFrame,
> > +        didFirstVisuallyNonEmptyLayoutForFrame,
> > +        didRemoveFrameFromHierarchy,
> > +        0, /* didDisplayInsecureContentForFrame */
> > +        0, /* didRunInsecureContentForFrame */
> > +        0, /* canAuthenticateAgainstProtectionSpaceInFrame */
> > +        0, /* didReceiveAuthenticationChallengeInFrame */
> > +        didStartProgress,
> > +        didChangeProgress,
> > +        didFinishProgress,
> > +        didBecomeUnresponsive,
> > +        didBecomeResponsive,
> > +        0,  /* processDidCrash */
> > +        0,  /* didChangeBackForwardList */
> > +        0   /* shouldGoToBackForwardListItem */
> > +    };
> 
> Shall we add all these functions to a different file? Maybe PageLoaderClient.

Yes, there's a FIXME with the same question indeed.

Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list