[Webkit-unassigned] [Bug 57923] Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 10 17:59:14 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57923
--- Comment #5 from Alice Boxhall <aboxhall at chromium.org> 2011-04-10 17:59:14 PST ---
(In reply to comment #2)
> (From update of attachment 88731 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88731&action=review
>
> > Source/WebCore/page/EventHandler.cpp:631
> > + Node* targetNode = EventHandler::targetNode(hitTestResult);
> > if (!targetNode)
>
> You should probably rename the local variable so that you don't have to resolve the name of member function like this.
Done.
> > Source/WebCore/page/EventHandler.cpp:642
> > + IntPoint localPoint = hitTestResult.localPoint();
> > + VisiblePosition targetPosition = targetRenderer->positionForPoint(localPoint);
>
> Why do you need to declare a local variable fot IntPoint?
No reason.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list