[Webkit-unassigned] [Bug 57535] Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 10 13:35:40 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57535
--- Comment #23 from David Levin <levin at chromium.org> 2011-04-10 13:35:40 PST ---
(In reply to comment #22)
> so including a "config.h" file which includes a pile of stuff is preferable to a surgical include with wtf/Platform.h? Whatever. I'll test your method and if it works, great, and I can be done with this patch and this disagreement.
Note including config.h in the cpp's not the header file.
"All implementation files must #include "config.h" first. Header files should never include "config.h"." -- http://www.webkit.org/coding/coding-style.html
Really the include of wtf/Platform.h is working around a problem in a cpp file. No header should have to include wtf/Platform.h The only thing I don't know is if we make exceptions in some odd cases but I'm not aware of them.
fwiw, I'm trying to help you. I'll admit that my note about sorting headers was off. At that point I wasn't looking at the patch. Only looking at and reacting to the notes about check-webkit-style giving false positives and a quick glance showed me this wasn't true.
if you feel that I'm not being helpful, I'm willing to go away and not touch this bug anymore.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list