[Webkit-unassigned] [Bug 57535] Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57535





--- Comment #21 from David Levin <levin at chromium.org>  2011-04-10 11:52:36 PST ---
(In reply to comment #20)
> Created an attachment (id=88949)
 --> (https://bugs.webkit.org/attachment.cgi?id=88949&action=review) [details]
> Patch to fix a compile issue on Solaris 10 with Sun Studio 12, which includes <sys/time.h>, updated per bug comments

OK the patch is well structured. Looking at the patch, I still believe what I said before is correct:

"It looks like the failures for the QT and cr-linux builds are because the files which include the header must not have the define for OS(). I believe this is in config.h, so I would make sure those files include it.  (The may involve modified a script which generates some files.)"

Specifically, I'm saying that the real problem is that there are cpp files which aren't doing #include "config.h" and fixing that is what should be done as opposed to including wtf/Platform.h

So I can't r+ this, but I'll leave this open (without an r- just in case some other reviewer really believes this is the correct way to address the issue).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.