[Webkit-unassigned] [Bug 57472] [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57472


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tonikitoo at webkit.org




--- Comment #9 from Antonio Gomes <tonikitoo at webkit.org>  2011-04-10 09:00:51 PST ---
(In reply to comment #8)
> This regression is caused by the patch launched in https://bugs.webkit.org/show_bug.cgi?id=33179, and I doubt that patch is correct.
> 
> First, I saw a problem in the unit test for that patch, in which it tries to insert a new line by sending a enter key event
> 
>     QKeyEvent keyEnter(QEvent::KeyPress, Qt::Key_Enter, Qt::NoModifier);
>     page->event(&keyEnter);
> 
> This is incorrect in Webkit, in order to adding a new line, we should add a text for the key event as below,
> 
>     QKeyEvent keyEnter(QEvent::KeyPress, Qt::Key_Enter, Qt::NoModifier, "\n");
>     page->event(&keyEnter);
> 
> Secondly, the issue in bug 33179 is a symbian platform only, which can't be reproduced on Linux. While, the patch impacts all the platforms and causes this regression.
> 
> I will take a look at the bug 33179 on symbian to see whether there is another way to fix it.

please comment in that bug, if you have not yet. It sounds really bad.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.