[Webkit-unassigned] [Bug 57535] Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57535





--- Comment #19 from Ben Taylor <bentaylor.solx86 at gmail.com>  2011-04-10 04:57:34 PST ---
(In reply to comment #18)
> (In reply to comment #15)
> > cosmetic fix, despite having logged bugs against check-webkit-style
> I see no bugs filed by you about check-webkit-style.

I know I filed one. Perhaps it was closed.

> Also I've looked at all issues mentioned in the bug and they are all real problems in your patches.
> 1. There should only be one space before end of line comments, so this
> # "header.h"        // This is for whatever.
> doesn't follow the proper style, but this does
> # "header.h" // This is for whatever.

Noted. Will make the fix. There are lots of place in webkit where
this was not followed, specifically made for "formatting" reasons.

> 2. Headers that aren't ifdef'ed are sorted.  Yours is not. I see
> #include <wtf/Platform.h>
>    occurring after things like
> #include <wtf/Vector.h>
> which isn't alphabetical.

Noted.  Will make the fix.  Obviously, sys/time.h will have to come after
wtf/Platform.h, since the macro protecting the include requires wtf/Platform.h

> 3. When you run check-webkit-style on a file without your changes and get other issues, you can actually see that it is working correctly. It did not point out these problems on your patches because they were not in lines that you changed. However, in the patches that you submitted, it is pointing out correct issues on correct lines. :)

Noted.

> PS check-webkit-style does have some issues at times but we strive to have them be pretty rare and none are exhibited in these issues as far as I see.

Will resubmit shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.