[Webkit-unassigned] [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 9 23:22:22 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=53625





--- Comment #17 from David Levin <levin at chromium.org>  2011-04-09 23:22:21 PST ---
(In reply to comment #14)
>  The patch is incorrect and will break svn-apply/unapply for all people with an SVN checkout on a Unix file system (this includes SVN under a default installation of Cygwin). ...

Thanks for the info. Rolled out. http://trac.webkit.org/changeset/83395

I suppose patch could be more sophisticated to look at the very first line ending of the file and use that to decided if we are dealing with DOS endings or not.

Would that work?

I really want to get this fixed as I hear about people hitting this often enough (and then I get pings to help land patches....)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list