[Webkit-unassigned] [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53625


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88946|review?                     |review+
               Flag|                            |




--- Comment #12 from Adam Barth <abarth at webkit.org>  2011-04-09 22:40:25 PST ---
(From update of attachment 88946)
View in context: https://bugs.webkit.org/attachment.cgi?id=88946&action=review

That's horrible, but also amazing.

> Tools/Scripts/svn-apply:335
> +            if (basename($fullPath) =~ "\.vcproj\$" || basename($fullPath) =~ "\.vsprops\$") {

I think there's some sneaky way of writing regular expressions in perl that avoids the need to \ the $.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.