[Webkit-unassigned] [Bug 58198] New: Clean up JSValue implementation for JSVALUE64.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58198

           Summary: Clean up JSValue implementation for JSVALUE64.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com


Remove JSNumberCell, JSImmediate, unify some methods between JSVALUE32_64/JSVALUE64

JSNumberCell.h largely just contained the constructors for JSValue on JSVALUE64, which should not have been here.  JSImmediate mostly contained uncalled methods, along with the internal implementation of the JSValue constructors split unnecessarily across a number of layers of function calls.  These could largely be merged back together.  Many methods and constructors from JSVALUE32_64 and JSVALUE64 can by unified.  The .cpp files are empty.

Moving all these methods into JSValue.h seems to be a repro measurable regression, so I have kept these methods in a separate JSValueInlineMethods.h.  Adding the 64-bit tag values as static const members of JSValue also measures as a repro regression, so I have made these #defines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.