[Webkit-unassigned] [Bug 58115] Gather data on modal dialogs shown during unload events

Sat Apr 9 00:23:03 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=58115

--- Comment #13 from Sreeram Ramachandran <sreeram at google.com>  2011-04-09 00:23:03 PST ---
(From update of attachment 88921)
View in context: https://bugs.webkit.org/attachment.cgi?id=88921&action=review

>>>>> Source/WebCore/page/Chrome.cpp:287
>>>>> +
>>>> 
>>>> I don't think you extract this as a function.
>>> 
>>> Meant to say "I don't think you should".
>> 
>> It will come in handy for the next patch (to actually disable dialogs), which uses this function in for example, canRunModalDialogNow(). I can unextract it now, and extract it out again in the next patch. Would you prefer that?
> 
> Yes, I'd prefer that.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.