[Webkit-unassigned] [Bug 58115] Gather data on modal dialogs shown during unload events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58115


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88878|review?                     |review-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-08 23:13:48 PST ---
(From update of attachment 88878)
View in context: https://bugs.webkit.org/attachment.cgi?id=88878&action=review

> Source/WebCore/ChangeLog:8
> +
> +        No new tests. (OOPS!)

You need to explain what kind of you change you're making here. Also, you need to replace "No new tests. (OOPS!)" by an explanation as to why you're not adding new tests.

> Source/WebCore/page/Chrome.cpp:63
> +static inline void willRunModalDialog(const Frame* frame, const ChromeClient::DialogType& dialogType, const ChromeClient* client)
> +{
> +    if (frame->loader()->pageDismissalEventBeingDispatched())
> +        client->willRunModalDialogDuringPageDismissal(dialogType);
> +}
> +

I don't think we normally define a function like this at the top of a file.  Instead, we put it right above where it first appears.  In this case, right before Chrome::runJavaScriptAlert.

> Source/WebKit/chromium/ChangeLog:7
> +

You need to explain what kind of change you're making here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.