[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 15:56:09 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=55571


Jessie Berlin <jberlin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jberlin at webkit.org




--- Comment #67 from Jessie Berlin <jberlin at webkit.org>  2011-04-08 15:56:08 PST ---
(In reply to comment #64)
> Committed r83344: <http://trac.webkit.org/changeset/83344>

Why is the UNLESS_ENABLED macro ok? Why should we be compiling this code with empty stubs for features that are not enabled? Why not compile it out instead of potentially adding runtime overhead and introducing subtle bugs because someone calls something that is not enabled and it doesn't fail at compile-time?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list