[Webkit-unassigned] [Bug 53020] [Meta] Convert HTMLMediaElement to use the new shadow DOM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53020





--- Comment #19 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-04-08 14:02:15 PST ---
(From update of attachment 88736)
View in context: https://bugs.webkit.org/attachment.cgi?id=88736&action=review

>> Source/WebCore/html/shadow/MediaControls.cpp:373
>> +        m_fullScreenButton->hide();
> 
> Why do this when the network state changes? The availability of state-based controls (eg. fullscreen, captions, volume) is based on media features so it might be better to do this when the readyState changes.

I am going to investigate this after landing. Feeling skittish about changing the logic now :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.