[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 13:09:29 PDT 2011


--- Comment #63 from MORITA Hajime <morrita at google.com>  2011-04-08 13:09:29 PST ---
Hi Darin, thank you for reviewing!
I'll land this after addressing you feedback.

> > Source/WebCore/editing/SpellingCorrectionController.h:83
> > +    SpellingCorrectionController(Frame*) UNLESS_ENABLED({})
> > +    ~SpellingCorrectionController() UNLESS_ENABLED({})
> This technique with all the macros on each function seems a little ugly to me, but I have no better suggestion.
I have same impression. One possible idea is to provide empty abstract class.
But it will have some performance penalty and I just gave it up at this time.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list