[Webkit-unassigned] [Bug 57835] [GTK] Initial loader client implementation in WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57835





--- Comment #5 from Alejandro G. Castro <alex at igalia.com>  2011-04-08 13:07:33 PST ---
(From update of attachment 88441)
View in context: https://bugs.webkit.org/attachment.cgi?id=88441&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:120
> +
> +    g_object_class_install_property(gobjectClass,
> +                                    PROP_TITLE,
> +                                    g_param_spec_string("title",
> +                                                        "Title",
> +                                                        "Returns the @web_view's document title",
> +                                                        0,
> +                                                        G_PARAM_READABLE));
> +    g_object_class_install_property(gobjectClass,
> +                                    PROP_URI,
> +                                    g_param_spec_string("uri",
> +                                                        "URI",
> +                                                        "Returns the current URI of the contents displayed by the @web_view",
> +                                                        0,
> +                                                        G_PARAM_READABLE));
> +    g_object_class_install_property(gobjectClass,
> +                                    PROP_PROGRESS,
> +                                    g_param_spec_double("progress",
> +                                                        "Progress",
> +                                                        "Determines the current progress of the load",
> +                                                        0.0, 1.0, 1.0,
> +                                                        G_PARAM_READABLE));

Maybe stating to add the doc of the API it is a good idea.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:139
> +    // TODO: update load-status property

In this cases we are using NotImplemented without the TODO comment, I would stick to that and add the comment just in case it adds any other information.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:287
> +    WKPageLoaderClient loadClient = {
> +        0,       /* version */
> +        webView, /* clientInfo */
> +        didStartProvisionalLoadForFrame,
> +        didReceiveServerRedirectForProvisionalLoadForFrame,
> +        didFailProvisionalLoadWithErrorForFrame,
> +        didCommitLoadForFrame,
> +        didFinishDocumentLoadForFrame,
> +        didFinishLoadForFrame,
> +        didFailLoadWithErrorForFrame,
> +        0, /* didSameDocumentNavigationForFrame */
> +        didReceiveTitleForFrame,
> +        didFirstLayoutForFrame,
> +        didFirstVisuallyNonEmptyLayoutForFrame,
> +        didRemoveFrameFromHierarchy,
> +        0, /* didDisplayInsecureContentForFrame */
> +        0, /* didRunInsecureContentForFrame */
> +        0, /* canAuthenticateAgainstProtectionSpaceInFrame */
> +        0, /* didReceiveAuthenticationChallengeInFrame */
> +        didStartProgress,
> +        didChangeProgress,
> +        didFinishProgress,
> +        didBecomeUnresponsive,
> +        didBecomeResponsive,
> +        0,  /* processDidCrash */
> +        0,  /* didChangeBackForwardList */
> +        0   /* shouldGoToBackForwardListItem */
> +    };

Shall we add all these functions to a different file? Maybe PageLoaderClient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.