[Webkit-unassigned] [Bug 57463] [GTK] ARIA tables not exposing cells as HTML tables do

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57463


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88393|review?                     |review+
               Flag|                            |




--- Comment #11 from chris fleizach <cfleizach at apple.com>  2011-04-08 08:47:37 PST ---
(From update of attachment 88393)
View in context: https://bugs.webkit.org/attachment.cgi?id=88393&action=review

r=me after you address comments.

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:110
> +            addChild(child.get(), appendedRows, columnCount);

if the ariaRoleAttribute == RowRole, is it not always isTableRow() = true?

> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:64
> +        return 0;

seems like this check is not necessary since when we ask for the parent unignored, we'll check again for accessibilityTable() a few lines below. 
I would however add a comment why we need to check parentObjectUnignored(), and the parentObjectUnignored() again

> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:90
> +        for (unsigned k = 0; k < siblings.size(); ++k) {

don't call .size() in the for loop (that means you'll call a method for every iteration

> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:93
> +                break;

i should note that if ARIA grid cells do have span columns, this code will be invalid

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.