[Webkit-unassigned] [Bug 57927] Add mock implementation and plumbing code for unified Quota API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57927





--- Comment #10 from David Levin <levin at chromium.org>  2011-04-08 07:12:06 PST ---
(From update of attachment 88783)
View in context: https://bugs.webkit.org/attachment.cgi?id=88783&action=review

Seems fine. Only one question before I r+.

> Source/WebKit/chromium/src/StorageInfoChromium.cpp:57
> +        webFrame->client()->queryStorageUsageAndQuota(webFrame, static_cast<WebStorageQuotaType>(storageType), WebStorageQuotaCallbacksImpl::createForUsageCallback(successCallback, errorCallback));

How do we know that storageType has a valid value?

What will happen if it doesn't?

Do we need to check for validity here?

> Source/WebKit/chromium/src/StorageInfoChromium.cpp:72
> +        webFrame->client()->requestStorageQuota(webFrame, static_cast<WebStorageQuotaType>(storageType), newQuotaInBytes, WebStorageQuotaCallbacksImpl::createForQuotaCallback(successCallback, errorCallback));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.