[Webkit-unassigned] [Bug 58118] Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58118


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88802|review?                     |review+
               Flag|                            |




--- Comment #7 from Yury Semikhatsky <yurys at chromium.org>  2011-04-08 05:24:49 PST ---
(From update of attachment 88802)
View in context: https://bugs.webkit.org/attachment.cgi?id=88802&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:182
> +        // FIXME: replace with input validation.

Please file a bug and put its number next to the FIXME

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:225
> +    if (!location->getString("sourceID", &sourceId) || !location->getNumber("lineNumber", &lineNumber)) {

This code repeats twice, consider extracting a method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.