[Webkit-unassigned] [Bug 56586] Media Stream API: add the getUserMedia method and the Javascript bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56586





--- Comment #39 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-04-08 04:04:58 PST ---
(From update of attachment 88637)
View in context: https://bugs.webkit.org/attachment.cgi?id=88637&action=review

>> LayoutTests/fast/dom/MediaStream/script-tests/enabled.js:3
>> +function hasGeolocationProperty()
> 
> Geolocation ?!

Sorry, I missed that one. Fixed.

>> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:54
>> +    if (exec->hadException() || !successCallback)
> 
> Do you need to check !successCallback? checkFunctionOnlyCallback is called with no flags so will only return null when it sets an exception. Can JSNavigatorUserMediaSuccessCallback::create() return null?

Fixed.

>> Source/WebCore/page/NavigatorUserMediaError.h:37
>> +        PERMISSION_DENIED = 1
> 
> Maybe add a comment that these values need to kept in sync with those in the IDL?

Fixed.

>> Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl:2
>> + * Copyright (C) 2011 Apple Inc. All rights reserved.
> 
> Google Inc - throughout

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.