[Webkit-unassigned] [Bug 58064] Web Inspector: Network events don't preserves, when inspector frontend closed and open again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 02:32:31 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58064


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-04-08 02:32:31 PST ---
Attachment 88786 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorFrontendProxy.cpp:68:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/inspector/InspectorResourceAgent.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/inspector/InspectorResourceAgent.cpp:54:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/inspector/EventsCollector.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/inspector/EventsCollector.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/inspector/EventsCollector.cpp:52:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/inspector/EventsCollector.cpp:55:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/inspector/InspectorFrontendProxy.h:40:  The parameter name "collector" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorFrontendProxy.h:41:  The parameter name "collector" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorFrontendProxy.h:41:  The parameter name "channel" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 10 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list