[Webkit-unassigned] [Bug 57923] Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 00:28:04 PDT 2011


--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-08 00:28:04 PST ---
(From update of attachment 88731)
View in context: https://bugs.webkit.org/attachment.cgi?id=88731&action=review

> Source/WebCore/page/EventHandler.cpp:631
> +    Node* targetNode = EventHandler::targetNode(hitTestResult);
>      if (!targetNode)

You should probably rename the local variable so that you don't have to resolve the name of member function like this.

> Source/WebCore/page/EventHandler.cpp:642
> +    IntPoint localPoint = hitTestResult.localPoint();
> +    VisiblePosition targetPosition = targetRenderer->positionForPoint(localPoint);

Why do you need to declare a local variable fot IntPoint?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list