[Webkit-unassigned] [Bug 54707] Introduce lookup-table based approach for applying CSS properties.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 00:25:42 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #57 from Nikolas Zimmermann <zimmermann at kde.org>  2011-04-08 00:25:40 PST ---
I'm reopening the bug. Most of the issues I commented when reviewing, have not been fixed.
New code is being added to CSSStyleProperty now, and I still dislike the structure.

Could you fix the existing issues first, before moving new props to the new concept?
Especially the CSSStyleApplyProperty.cpp file that now contains several template classes is confusing.

What I mean here is: we had one big file with lots of switch/case statements, now we have a new file, that will contain a template class for each property - that's not a benefit in any way. We want to have seperated files for each property, even better in a new subdirectory in css, making it more maintainable.

Please lets not degenerate CSSStyleApplyProperty to a does-it-all-class.
I still want to see the typedefs for the function pointers, renames for the inherit/initial functions etc... :(

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list