[Webkit-unassigned] [Bug 56942] EventSource should only accept UTF-8 charset

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 17:35:12 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56942





--- Comment #17 from Julien Chaffraix <jchaffraix at webkit.org>  2011-04-07 17:35:12 PST ---
> > LayoutTests/ChangeLog:21
> > +        in the URL. Also added a work-around a bug in PHP.
> 
> I don't think that it's a bug. A quick web search suggested that it's a configuration option, and we should do something like:
> 
> if (get_magic_quotes_gpc()){
>     $value = stripslashes($value);
> }
> 
> See also: <http://php.net/manual/en/function.stripslashes.php>, <http://php.net/manual/en/function.get-magic-quotes-gpc.php>.

Indeed. I should have expected some different options on Mac. Do we know why the configuration is different between Linux and Mac? It looks like something that will bite us at some point and would like to fix.

> > LayoutTests/http/tests/eventsource/eventsource-content-type-charset.html:35
> > +                     'text/event-stream; charset=windows-1152',
> 
> Did you mean to use a non-existent charset here? If so, 1152 is an overly subtle way to express that.

No, this is a typo. Changed it to windows-1251 as the logic does not care if the charset exists or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list