[Webkit-unassigned] [Bug 58063] CTLine objects should outlive their CTRuns

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 17:15:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58063


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #5 from mitz at webkit.org  2011-04-07 17:15:51 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 88732 [details] [details])
> > If the CTLine stays alive, then maybe ComplexTextRun::m_coreTextRun no longer needs to be a RetainPtr?
> 
> Good idea! Should it become a different smart pointer or will a bare CTRunRef suffice?

Bare CTRunRef. A comment right above the member variable definition explaining why it’s ok to use a bare CTRunRef would be good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list