[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55571





--- Comment #54 from MORITA Hajime <morrita at google.com>  2011-04-07 16:33:12 PST ---
Jia, Darin, thank you for your responsive investigation!
I updated the patch, Could you have  another try ?
Thanks in advance.

> 
> > Source/WebCore/editing/SpellingCorrectionController.cpp:159
> > +void SpellingCorrectionController::show(PassRefPtr<Range> rangeToReplace, const String& replacement)
> > +{
> > +    FloatRect boundingBox = windowRectForRange(rangeToReplace.get());
> > +    if (boundingBox.isEmpty())
> > +        return;
> > +    m_correctionPanelInfo.rangeToBeReplaced = rangeToReplace;
> 
> After this assignment, rangeToReplace has a null pointer.
I trapped PassRefPtr trap... Fixed.

> 
> > Source/WebCore/editing/SpellingCorrectionController.cpp:160
> > +    m_correctionPanelInfo.replacedString = plainText(rangeToReplace.get());
> 
> Now the return value of plainText() will be an empty string.
Fixed by above change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.