[Webkit-unassigned] [Bug 57888] Need to extend WebKit chromium API to access text selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57888





--- Comment #7 from Varun Jain <varunjain at chromium.org>  2011-04-07 15:58:29 PST ---
(In reply to comment #5)
> (From update of attachment 88446 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88446&action=review
> 
> > Source/WebKit/chromium/public/WebWidget.h:132
> > +    // TODO(varunjain): make this pure virtual after all downstream classes have
> 
> nit: we use FIXME instead of TODO(user) in webkit

Done

> 
> there should be no downstream implementations of this interface.  why is this needed?

I dont know how or why but someone put an implementation of WebWidget in content/renderer/render_widget_fullscreen_pepper.cc :(
so I break chromium if I make that method pure virtual
thats why I need to do the fix in 3 parts... my current CL + chrome CL to add the method in that implementation + webkitCL to make the method pure virtual

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.