[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55571





--- Comment #51 from Jia Pu <jpu at apple.com>  2011-04-07 15:51:30 PST ---
(From update of attachment 88686)
View in context: https://bugs.webkit.org/attachment.cgi?id=88686&action=review

> Source/WebCore/editing/SpellingCorrectionController.cpp:159
> +void SpellingCorrectionController::show(PassRefPtr<Range> rangeToReplace, const String& replacement)
> +{
> +    FloatRect boundingBox = windowRectForRange(rangeToReplace.get());
> +    if (boundingBox.isEmpty())
> +        return;
> +    m_correctionPanelInfo.rangeToBeReplaced = rangeToReplace;

After this assignment, rangeToReplace has a null pointer.

> Source/WebCore/editing/SpellingCorrectionController.cpp:160
> +    m_correctionPanelInfo.replacedString = plainText(rangeToReplace.get());

Now the return value of plainText() will be an empty string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.