[Webkit-unassigned] [Bug 57813] Support a list of nodes at the top level of a shadow DOM tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57813


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88682|1                           |0
        is obsolete|                            |




--- Comment #13 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-04-07 13:37:21 PST ---
(From update of attachment 88682)
View in context: https://bugs.webkit.org/attachment.cgi?id=88682&action=review

Super close! One more rinse cycle.

> Source/WebCore/dom/ShadowRoot.cpp:35
> +PassRefPtr<ShadowRoot> ShadowRoot::create(Document* document)
> +{
> +    return adoptRef(new ShadowRoot(document));
> +}

This can be inlined in the header. See http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.h&l=76.

> Source/WebCore/html/HTMLKeygenElement.cpp:130
> +    return static_cast<HTMLSelectElement*>(shadowRoot()->firstChild());

I'd do the same check for shadowRoot() here as you did for slider thumb.

> Source/WebCore/html/RangeInputType.cpp:200
> +    RefPtr<ShadowRoot> shadow = ShadowRoot::create(element()->document());

Whoops. This one's not used anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.