[Webkit-unassigned] [Bug 58047] Web Inspector: remove "enabled" from the setBreakpoint protocol.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58047


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88658|review?                     |review+
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2011-04-07 10:41:21 PST ---
(From update of attachment 88658)
View in context: https://bugs.webkit.org/attachment.cgi?id=88658&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:123
> +                breakpoint.debuggerId = breakpointData.debuggerId;

Extract method.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:168
> +        if (!sourceFile)

Please remove this, it never happens.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274
> +            this._breakpointAdded(breakpoint);

New breakpoint set should be saved.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:339
> +            this._removeBreakpointFromDebugger(breakpoint);

please pass afterUpdate as a callback to _removeBreakpointFromDebugger

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:395
> +    _breakpointRemoved: function(breakpoint)

Please inline this method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.