[Webkit-unassigned] [Bug 57849] [Chromium] Add WebKit API to query and request unified offline-storage quota

Thu Apr 7 09:14:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57849

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88582|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #14 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-04-07 09:14:09 PST ---
(From update of attachment 88582)
View in context: https://bugs.webkit.org/attachment.cgi?id=88582&action=review

R=me because my nit picks are very minor.  Feel free to correct those and then commit.

> Source/WebKit/chromium/public/WebStorageQuotaError.h:38
> +    WebStorageQuotaErrorOk = 0,

do you need the "ok" value?  i can't imagine didFail being called with this value.

> Source/WebKit/chromium/public/WebStorageQuotaError.h:40
> +    WebStorageQuotaErrorSecurity = 18,

it is not very obvious what ErrorSecurity and ErrorAbort mean.  i think ErrorAbort
will be used whenever the operation could not complete because we are shutting down.
what does ErrorSecurity mean?

maybe the name could be improved or maybe a comment could be added or both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.