[Webkit-unassigned] [Bug 56855] [GTK] Unify accessibility role names in DRT for GTK and Mac platforms

Thu Apr 7 07:19:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56855

--- Comment #8 from Mario Sanchez Prada <msanchez at igalia.com>  2011-04-07 07:19:46 PST ---
Created an attachment (id=88630)
 --> (https://bugs.webkit.org/attachment.cgi?id=88630&action=review)
Patch for fixing this (asking for opinion)

Hi again Chris,

Inspired by your suggestion of adding something like isMac()/isGTK() methods to DRT, I wrote the attached patch this morning, which would basically add a new property in the layoutController so we could easily check, from cross-platform layout tests, the name of the platform in use: "gtk", "mac", "wx"...

I found it specially useful when working on unskipping the accessibility/input-slider.html test, which has a part that doesn't apply to GTK (GTK won't expose objects of role SliderThumbRole), but the rest could be the same, providing we do not check rolenames in the test itself either, but just print them and check them in the expected files. See bug 58040 for more details.

Anyway, I'm not currently asking for review over this patch but more for an opinion (that's why I didn't mark bug 58040 as depending on this one). Well, and also to check through the EWS whether I broke or not compilation in other platforms, since I did changes for platforms other than GTK blindly.

If we agree it could be a good idea, then I would come with a proper patch, with a proper Changelog and perhaps with a new bug just for it (unless we found 'just ok' to use this one for that purpose, which I guess could be ok as well).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.