[Webkit-unassigned] [Bug 58025] Web Inspector: Bugs in some corner cases in the text editor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58025





--- Comment #4 from Andrey Adaikin <aandrey at chromium.org>  2011-04-07 07:14:16 PST ---
(From update of attachment 88605)
View in context: https://bugs.webkit.org/attachment.cgi?id=88605&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> ChangeLog entry should briefly explain the change, please don't leave it empty.

done.

>> Source/WebCore/inspector/front-end/TextViewer.js:1145
>> +        for (var lineRow = element; lineRow; lineRow = lineRow.parentElement) {
> 
> Why not use this loop exclusively without relying on the class name above?

Because an element may not be attached to the this._container any more (e.g. after a DOMNodeRemoved event). The loop is to handle the odd case when the browser would insert a line-row without the "webkit-line-content" className right under the this._container.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.