[Webkit-unassigned] [Bug 57949] Web Inspector: get rid of Breakpoint.js.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57949





--- Comment #3 from Pavel Podivilov <podivilov at chromium.org>  2011-04-07 06:09:26 PST ---
(From update of attachment 88611)
View in context: https://bugs.webkit.org/attachment.cgi?id=88611&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:323
> +            var scriptLocation = breakpoint.location ? breakpoint.location : {lineNumber:breakpoint.lineNumber, columnNumber:0};

Here breakpoint.lineNumber may denote location in formatter script. We should not map it in that case.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:371
> +            var pendingBreakpoints = this._breakpointsWithoutSourceFile[sourceFileId];

Please mind that sourceFileId would be undefined for all breakpoints created with the old version. When such breakpoints would be purged? Probably it's better to ignore them here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.