[Webkit-unassigned] [Bug 31500] webkit-patch land hangs if svn prompts for credentials

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31500





--- Comment #16 from Peter Gal <galpeter at inf.u-szeged.hu>  2011-04-07 05:26:51 PST ---
(In reply to comment #15)
> (From update of attachment 88597 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88597&action=review
> 
> > Tools/Scripts/webkitpy/tool/main.py:52
> > +        make_option("-p", "--password", action="store_true", dest="prompt_password", default=False, help="prompt for password"),
> 
> Why should you have to pass an option in order to enter a password?  I would have expected webkit-patch to prompt you for a password if you needed it.
> 
> Ideally, if we could detect that a password was needed, we could handle this all at the scm.py layer.
> 

As I mentioned this is just a proof-of-concept fix for the problem. Password detection could be added later, if this fixes the initial problem. 

> > Tools/Scripts/webkitpy/tool/steps/commit.py:28
> > +import getpass
> 
> This looks extra.
> 
> > Tools/Scripts/webkitpy/tool/steps/commit.py:70
> > -                commit_text = scm.commit_with_message(self._commit_message, git_commit=self._options.git_commit, username=username, force_squash=force_squash, changed_files=self._changed_files(state))
> > +                commit_text = scm.commit_with_message(self._commit_message, git_commit=self._options.git_commit,
> > +                                                      username=username, force_squash=force_squash,
> > +                                                      changed_files=self._changed_files(state), input=password)
> 
> instead of "input=password", it seems like we'd want to say "password=password".
I overlooked these during the update. 

I'll update the patch with the password detection in a minute. Stay tuned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.