[Webkit-unassigned] [Bug 58007] [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58007


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88558|review?                     |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2011-04-07 03:15:01 PST ---
(From update of attachment 88558)
View in context: https://bugs.webkit.org/attachment.cgi?id=88558&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:791
> -        setWindowState(Qt::WindowNoState);
> +        if (m_windowOptions.preferMaximized)
> +            setWindowState(Qt::WindowMaximized);
> +        else
> +            setWindowState(Qt::WindowNoState);

I think the window should come back in its previous state when going out of fullscreen.

> Tools/QtTestBrowser/launcherwindow.cpp:883
> +    if (m_windowOptions.preferMaximized)
> +        dialog->setWindowState(Qt::WindowMaximized);
> +    else
> +        dialog->resize(size().width() * 0.7, dialog->size().height());

This is a dialog, that should not get maximized by default. The window manager should decide how to handle dialogs.

> Tools/QtTestBrowser/main.cpp:186
> +             << "[-maximized"

Missing ]


Same comments for both apps.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.