[Webkit-unassigned] [Bug 57948] JSC bindings generator: support non-object numbers as callback arguments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 6 18:58:01 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57948
--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org> 2011-04-06 18:58:01 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 88424 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=88424&action=review
> >
> > > Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp:141
> > > +bool JSTestCallback::callbackWithInteger(int* intParam)
> > > +{
> > > + if (!canInvokeCallback())
> > > + return true;
> > > +
> > > + RefPtr<JSTestCallback> protect(this);
> > > +
> > > + JSLock lock(SilenceAssertionsOnly);
> > > +
> > > + MarkedArgumentBuffer args;
> > > + args.append(jsNumber(static_cast<int>(intParam)));
> >
> > This is definitely wrong and won’t even compile. You can’t just cast an int* to an int.
>
> Hmm, it has compiled and worked in my testing environment. Looking into the generated JS file, the callback method seems to be given a int parameter (or long long parameter if we pass a long long one). Would you mind giving some hint how I could fix the code?
Ah ok, the generated test code looks wrong. Let me take a look at it again.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list