[Webkit-unassigned] [Bug 57812] Re-entrancy issue with setIsAcceleratedCompositingActive

Wed Apr 6 17:49:39 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57812

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88181|review?                     |review-
               Flag|                            |

--- Comment #6 from Kenneth Russell <kbr at google.com>  2011-04-06 17:49:39 PST ---
(From update of attachment 88181)
View in context: https://bugs.webkit.org/attachment.cgi?id=88181&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2425
> +            m_temporaryOnscreenGraphicsContext3D = 0;

This needs to occur in both code paths, whether or not the LayerRendererChromium succeeded in being created, to avoid a resource leak. I suggest using m_temporaryOnscreenGraphicsContext3D.clear() to do so.

As long as you're convinced that there are no other problems in allowing the reentrancy, this otherwise looks fine. Please upload a revised patch (and set cq?) and I'll r+ it. Note that the 'webkit-patch upload' script assists with this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.