[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27551





--- Comment #135 from Kevin Ollivier <kevino at theolliviers.com>  2011-04-06 17:41:56 PST ---
(In reply to comment #134)
> (From update of attachment 88543 [details])
> Wow, does it really have to be done on every function like this? I guess I shouldn’t be all that surprised, but still, I’m surprised about inline functions like isHashTableDeletedValue needing this.

If we don't export the whole class, yes. As for why we need it for inline methods, I haven't found a clear answer (other than that the linker complains about undefined symbols if I don't :), but my guess is that we need it on the inline functions because the WTFString class itself is private, so the compiler probably doesn't have a visible class vtable to bind the inline method to. 

IMHO, at least in terms of WTF, I think it makes a lot of sense to just declare the classes themselves as exported if there's more than a couple methods used. It is supposed to be a helper library, and I don't think there is the intent to discourage use of WTF outside of JSCore, so I would think we'd eventually want there to be a public API for it, at least in principle.

In any case, I'll handle things however you guys think best. I'd just like to see this resolved so I don't have to maintain my own export symbol list on wx just to get DRT going. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.