[Webkit-unassigned] [Bug 57995] New: Unnecessary string allocation in CSSStyleDeclaration::setProperty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 15:53:55 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57995

           Summary: Unnecessary string allocation in
                    CSSStyleDeclaration::setProperty
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh Intel
        OS/Version: Mac OS X 10.6
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ianh at apple.com


In CSSStyleDeclaration::setProperty(const String&, const String&, ExceptionCode&), we construct a string, either "" or "important", depending on the priority of the property.  We then pass this value to CSSStyleDeclaration::setProperty(const String&, const String&, const String&, ExceptionCode&), which parses the value out of the string again.  We should just pass the bool directly, without going through an intermediate string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list