[Webkit-unassigned] [Bug 40254] [Qt] FrameLoaderClientQt.cpp has coding-style errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 15:14:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=40254


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88467|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-04-06 15:14:32 PST ---
(From update of attachment 88467)
View in context: https://bugs.webkit.org/attachment.cgi?id=88467&action=review

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:97
> +static QString drtDescriptionSuitableForTestResult(WebCore::Frame* webCoreFrame)

We normally just say coreFrame in Qt parts where we want to differentiate

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:252
> +    // notImplemented();

I dont get why that is outcommented... either remove the comment or remove the line

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list