[Webkit-unassigned] [Bug 57968] [GTK] Need a way to get the path for a WebKitWebPlugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57968





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-04-06 14:25:41 PST ---
(From update of attachment 88483)
View in context: https://bugs.webkit.org/attachment.cgi?id=88483&action=review

> Source/WebKit/gtk/webkit/webkitwebplugin.cpp:179
> + * Returns: the absolute path for @plugin.

Nit! "the absolute path for @plugin" --> "the absolute path to the @plugin"

> Source/WebKit/gtk/webkit/webkitwebplugin.cpp:192
> +    if (!priv->path.length())
> +        priv->path = priv->corePlugin->path().utf8();
> +
> +    return priv->path.data();

I think this should return the path in the filesystem encoding. For instance, g_fopen takes filenames in the system encoding. Either way the documentation should be clear about what encoding is returned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.