[Webkit-unassigned] [Bug 57964] Fast path for parsing simple CSS values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57964





--- Comment #6 from Antti Koivisto <koivisto at iki.fi>  2011-04-06 13:54:02 PST ---
(From update of attachment 88473)
View in context: https://bugs.webkit.org/attachment.cgi?id=88473&action=review

> Source/WebCore/css/CSSParser.cpp:308
> +        CSSProperty property(id, CSSPrimitiveValue::createIdentifier(valueID), important);

You should construct CSSPrimitiveValue using CSSPrimitiveValueCache. That hangs from the document which you can get through the style declaration.

> Source/WebCore/css/CSSParser.cpp:316
> +    CSSProperty property(id, CSSPrimitiveValue::createColor(color), important);

You should construct CSSPrimitiveValue using CSSPrimitiveValueCache. That hangs from the document which you can get through the style declaration.

> Source/WebCore/css/CSSParser.cpp:384
> +    CSSProperty property(id, CSSPrimitiveValue::create(number, unit), important);

You should construct CSSPrimitiveValue using CSSPrimitiveValueCache. That hangs from the document which you can get through the style declaration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.