[Webkit-unassigned] [Bug 57964] Fast path for parsing simple CSS values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57964





--- Comment #4 from Dave Hyatt <hyatt at apple.com>  2011-04-06 13:43:43 PST ---
(From update of attachment 88473)
View in context: https://bugs.webkit.org/attachment.cgi?id=88473&action=review

>> Source/WebCore/css/CSSParser.cpp:262
>> +static bool isSimpleColorPropertyID(int id)
> 
> Make inline?

It's not clear to me why we need to call this "isSimpleColorPropertyID"... as opposed to what... a complex color property ID?  It also seems like a bunch of color properties are missing from this list. What about outline-color and all of the various SVG color properties?

> Source/WebCore/css/CSSParser.cpp:288
> +static bool parseSimpleColorValue(CSSMutableStyleDeclaration* declaration, int id, const String& string, bool important, bool strict)

Are there colors you're omitting on purpose? Still not clear on the terminology unless maybe that's the case....

> Source/WebCore/css/CSSParser.cpp:322
> +static bool isSimpleDimensionPropertyID(int id, bool& acceptsNegativeNumbers)

What about the padding properties?  Also, as SImon points out, I don't think "dimension" is a good term here, since that has meaning in CSS.  I would use Length.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.