[Webkit-unassigned] [Bug 57804] Various layout tests depend on mp4 files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57804


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88169|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2011-04-06 12:02:55 PST ---
(From update of attachment 88169)
View in context: https://bugs.webkit.org/attachment.cgi?id=88169&action=review

Great change, but I would prefer to have it split into three bugs so r- for now.

> LayoutTests/ChangeLog:16
> +        Fix the following which became exposed after unblocking the core format
> +        problem:
> +
> +        - update video-load-and-stall.cgi to take a time to stall for. Previously the
> +        cgi script would just exit on stall, which can (should?) be interpreted as a
> +        network error rather than a stall (which requires 3 seconds before firing).
> +
> +        - video-play-before-metadata.html was waiting for a suspend event which isn't
> +        expected (in the *-expected.txt file). The suspend event is 'likely' to come
> +        after the onload, but might come before, making this test flakey.

I think it is worth fixing each of these in separate bugs because you are doing more than changing the test file used.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.