[Webkit-unassigned] [Bug 57806] continue experiment with moving caret by word in visual order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57806





--- Comment #11 from Xiaomei Ji <xji at chromium.org>  2011-04-06 10:38:18 PST ---
(In reply to comment #10)
> (From update of attachment 88319 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88319&action=review
> 
> >>> Source/WebCore/editing/visible_units.cpp:1232
> >>> +static bool positionIsVisuallyOrderedInBox(const VisiblePosition& wordBreak, const InlineBox* box, int& offsetOfWordBreak)
> >> 
> >> I don't think positionIsVisuallyOrderedInBox is a descriptive name here.  It explains what the function is checking but it doesn't explain anything in the context of nextWordBreakInBoxInsideBlockWithDifferentDirectionality.  Please rename.
> > 
> > The function is named as what it does, does not matter what the context is. As to it is only needed when block and box has different directionality, I think that should be explained in the caller, as in the current code.
> > Or suggestion on a better name?
> 
> I disagree. We should name a function to explain for what purpose the function is used especially because this function is only used in one place.

suggestion for a better name?
positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.